[libcxx-commits] [PATCH] D92240: [libc++] Consistently unparenthesize `numeric_limits<T>::max`. NFCI.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Nov 28 06:36:21 PST 2020


Quuxplusone added a comment.

In D92240#2421040 <https://reviews.llvm.org/D92240#2421040>, @curdeius wrote:

> In D92240#2420684 <https://reviews.llvm.org/D92240#2420684>, @Quuxplusone wrote:
>
>> I wouldn't mind making the patch for barrier/latch/semaphore (basically D68480 <https://reviews.llvm.org/D68480> should have added them to lists-of-all-the-headers in a couple more places than it did, and `min_max_macros.compile.pass.cpp` was one of those places)
>
> @ldionne, should that be added to NOTES.txt/(future)contributing.rst?
> @Quuxplusone, are there any other places you found?

Technically no, I hadn't looked. But now that I've looked, yes, of the places I know as "big lists of headers", the new synchronization-primitive headers are missing from exactly two of them:
include/CMakeLists.txt (OK)
include/module.modulemap (OK)
test/libcxx/double_include.sh.cpp (OK)
test/libcxx/min_max_macros.compile.pass.cpp (missing)
test/libcxx/no_assert_include.compile.pass.cpp (missing)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92240/new/

https://reviews.llvm.org/D92240



More information about the libcxx-commits mailing list