[libcxx-commits] [PATCH] D92229: [libc++] Update clang-format configuration

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I think it's clear that we'll benefit from clang-format.

However, Marshall does have a point that sometimes, you want to format things in a specific way and not have clang-format mess it up. I think it's fine to use `// clang-format off` for those cases.

@curdeius Could you add a CI job that makes sure that the commit we're testing has been run through `git clang-format`? You could run it first in the pipeline, and we could even consider adding a `wait` step in the pipeline so that the rest of the pipeline doesn't run if you haven't `clang-format`ed your changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92229/new/

https://reviews.llvm.org/D92229