[libcxx-commits] [PATCH] D61170: Use std::move in numeric algorithms

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 23 13:50:13 PST 2020


ldionne accepted this revision.
ldionne added a comment.

Can you update the paper status in `www/`?

LGTM after CI passes and updating the paper status. Also consider the comment about comments on short `#endif`s, but it's non-blocking.



================
Comment at: include/numeric:453
+            *__result = __val - __acc;
+#endif // _LIBCPP_STD_VER > 17
+            __acc = _VSTD::move(__val);
----------------
These comments on the `#endif` don't add a lot of value since there's only one line in between. I think it would un-clutter the code a bit to remove them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61170/new/

https://reviews.llvm.org/D61170



More information about the libcxx-commits mailing list