[libcxx-commits] [PATCH] D88818: [libc++] Add missing XFAIL to tests that need __atomic_* libcalls

Fri Nov 20 12:13:50 PST 2020

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

So... do I understand correctly that you're only seeing issues on older FreeBSDs where `libcompiler_rt` does not contain `__atomic_load` & friends? Because macOS is in the same boat as FreeBSD: it doesn't ship `libatomic.a` (hence the need for the `non-lockfree-atomics` Lit feature).

You might also want to take a look at `libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_helpers.h` -- we seem to exclude large types from some tests on `__APPLE__` -- would also excluding them from `__FreeBsd__` solve your issues?

Requesting changes since this is breaking CI -- I'm not sure yet what we'll have to change, but we'll have to change something.

================
Comment at: libcxx/utils/libcxx/test/features.py:43
   Feature(name='modules-support',               when=lambda cfg: hasCompileFlag(cfg, '-fmodules')),
   Feature(name='non-lockfree-atomics',          when=lambda cfg: sourceBuilds(cfg, """
                                                                   #include <atomic>
----------------
The `non-lockfree-atomics` feature is defined here, but I assume you found it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88818/new/

https://reviews.llvm.org/D88818