[libcxx-commits] [PATCH] D90178: [SystemZ][ZOS] libcxx - no posix memalign

[Louis Dionne via Phabricator via libcxx-commits]

ldionne reopened this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D90178#2376073 <https://reviews.llvm.org/D90178#2376073>, @zibi wrote:

> @ldionne Louis, are you ok, with new addition added after your approval?

Sorry, but no I'm not. Let's not revert and talk.



================
Comment at: libcxx/CMakeLists.txt:525
+  # because they are provided by the dylib itself with the excepton of z/OS.
+  if (ZOS)
+    target_add_compile_flags_if_supported(${target} PRIVATE -fno-aligned-allocation)
----------------
Can you explain why you need this? IOW, what issue are you seeing if you use `-faligned-allocation`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90178/new/

https://reviews.llvm.org/D90178