[libcxx-commits] [PATCH] D91574: [libc++] Simplify how we pick the typeinfo comparison

Shafik Yaghmour via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 19 10:00:34 PST 2020


shafik added a comment.

In D91574#2405909 <https://reviews.llvm.org/D91574#2405909>, @ldionne wrote:

> 



> I don't disagree with how they deal with incremental builds -- I just think we should be fine with a bit of human intervention from time to time if we're going to assume the cache never gets invalidated. And at the same time, I suggested a technical approach (full build + `ccache`) to make the bots more robust so that these issues don't happen again in the future.

If you foresee the need for possible human intervention maybe the discussion about that should have happened before the change was landed? Then at least folks would have been prepared to fix the problem right after the it landed, assuming they agreed on that approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91574/new/

https://reviews.llvm.org/D91574



More information about the libcxx-commits mailing list