[libcxx-commits] [PATCH] D91574: [libc++] Simplify how we pick the typeinfo comparison

Thu Nov 19 01:52:06 PST 2020

fhahn added a comment.

In D91574#2404708 <https://reviews.llvm.org/D91574#2404708>, @lebedev.ri wrote:

> This seems to have broken no-op rebuild w/ existing build dir:
>
>   CMake Error at /repositories/llvm-project/libcxx/CMakeLists.txt:187 (message):
>     Value '' is not a valid value for
>   
>                            LIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION
>   
>   
>   -- Configuring incomplete, errors occurred!
>
> It seems to work after i manually specify `-DLIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION=default`, but still..

Same for me.

@ldionne would it be possible to adjust the default so that it doesn't break re-builds & works without explicitly having to set `DLIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91574/new/

https://reviews.llvm.org/D91574