[libcxx-commits] [PATCH] D91574: [libc++] Simplify how we pick the typeinfo comparison

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

You need to remove your build directory before running CMake. The issue is that CMake cache variables don't get overwritten with new values unless the cache is changed manually. If you don't remove the cache, it gets stale, and in this case, it's wrong.

Generally speaking, any CI job that doesn't either remove the whole build directory and start from scratch, or at least remove the CMake cache, is bound to be flaky and break in this way. This is a problem of the build job, not of this change.

Note that if you're trying to setup an incremental build and save on full rebuilds, I think it's better to use something like ccache than trying to keep the build directory around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91574/new/

https://reviews.llvm.org/D91574