[libcxx-commits] [PATCH] D91574: [libc++] Simplify how we pick the typeinfo comparison

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, jkorous, kristof.beyls, mgorny.
Herald added a project: libc++.
Herald added a reviewer: libc++.
ldionne requested review of this revision.

Selecting the right implementation for comparing typeinfos is not something
that we should configure in the config site. It's specific to the ABI in
use, and it should be detected automatically by the library. It has been
a source of confusion and bugs ever since we've introduced that.

Furthermore, it's really weird to set the comparison implementation
explicitly, yet for that choice not to be honored on arm64/Apple.

This commit removes the ability to explicitly select the implementation
of typeinfo comparison, and instead relies on the existing logic to select
the right one based on the ABI.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91574

Files:
  libcxx/CMakeLists.txt
  libcxx/cmake/caches/Apple.cmake
  libcxx/docs/BuildingLibcxx.rst
  libcxx/include/__config
  libcxx/include/__config_site.in
  libcxx/include/typeinfo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91574.305613.patch
Type: text/x-patch
Size: 7434 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201116/ad9c0481/attachment-0001.bin>