[libcxx-commits] [PATCH] D65041: Change requirements on linear_congruential_engine

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 10 16:40:56 PST 2020


zoecarver added a comment.

> For full disclosure, I'm relying on the tests a lot here because I am *not* a PRNG expert and I didn't take hours to research the algorithms in use. I'm trusting that you did look at other state of the art.

Neither am I. Not sure what you mean by "state of the art." I mainly went off the discussion of the bug and various online guides. An important note: this only changes how we pick what algorithm to use, it doesn't change any of the algorithms themselves.

Anyway, I'll fix the comments and land this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65041/new/

https://reviews.llvm.org/D65041



More information about the libcxx-commits mailing list