[libcxx-commits] [PATCH] D87171: Implement P0919R3

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I just noticed two small nits.



================
Comment at: libcxx/www/cxx2a_status.html:123
 	<tr><td><a href="https://wg21.link/P0899R1">P0899R1</a></td><td>LWG</td><td>P0899R1 - LWG 3016 is not a defect</td><td>San Diego</td><td><i>Nothing to do</i></td><td></td></tr>
-	<tr><td><a href="https://wg21.link/P0919R3">P0919R3</a></td><td>LWG</td><td>Heterogeneous lookup for unordered containers</td><td>San Diego</td><td><i> </i></td><td></td></tr>
+	<tr><td><a href="https://wg21.link/P0919R3">P0919R3</a></td><td>LWG</td><td>Heterogeneous lookup for unordered containers</td><td>San Diego</td><td>Complete</td><td></td></tr>
 	<tr><td><a href="https://wg21.link/P0972R0">P0972R0</a></td><td>LWG</td><td><chrono> <tt>zero()</tt>, <tt>min()</tt>, and <tt>max()</tt> should be noexcept</td><td>San Diego</td><td>Complete</td><td>8.0</td></tr>
----------------
Can you change this `<td>Complete</td><td></td>` to  `<td>Complete</td><td>12.0</td>` so it contains the proper release version?


================
Comment at: libcxx/www/cxx2a_status.html:204
 	<tr><td><a href="https://wg21.link/P1686">P1686</a></td><td>LWG</td><td>Mandating the Standard Library: Clause 27 - Time library </td><td>Belfast</td><td><i> </i></td><td></td></tr>
 	<tr><td><a href="https://wg21.link/P1690">P1690</a></td><td>LWG</td><td>Refinement Proposal for P0919 Heterogeneous lookup for unordered containers </td><td>Belfast</td><td><i> </i></td><td></td></tr>
 	<tr><td><a href="https://wg21.link/P1716">P1716</a></td><td>LWG</td><td>ranges compare algorithm are over-constrained </td><td>Belfast</td><td><i> </i></td><td></td></tr>
----------------
rarutyun wrote:
> ckennelly wrote:
> > Does this implementation take this paper into account?
> > 
> > It reworked the design of heterogeneous lookup from P919.
> Yes, it does. I wrote about that in some comments. Thanks for noticing. I didn't find it previously when I tried. Will also mark it as completed.
Can you change this `<td>Complete</td><td></td>` to  `<td>Complete</td><td>12.0</td>` so it contains the proper release version?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87171/new/

https://reviews.llvm.org/D87171