[libcxx-commits] [PATCH] D91175: [19/N] [libcxx] Fix the fallback case in temp_directory_path for windows

Saleem Abdulrasool via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 10 08:45:19 PST 2020


compnerd added inline comments.


================
Comment at: libcxx/src/filesystem/operations.cpp:1599
+#if defined(_LIBCPP_WIN32API)
+    ret = "c:\\windows";
+#else
----------------
What do you think of using `GetTempPath` instead?  That is more likely to be writable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91175/new/

https://reviews.llvm.org/D91175



More information about the libcxx-commits mailing list