[libcxx-commits] [PATCH] D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 10 01:29:12 PST 2020


mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

Also set the preferred separator to backslash.

libc++ doesn't compile successfully for windows prior to this change, and this change on its own isn't enough to make it compile successfully either, but is the first stepping stone towards making it work correctly.

Most of operations.cpp will need to be touched, both for calling functions that take wchar paths, but also for using other windows specific functions instead of the posix functions used so far; that is handled in later commits.

Changing parts of operations.cpp to generalize the string type handling in code that doesn't touch system functions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91135

Files:
  libcxx/include/filesystem
  libcxx/src/filesystem/filesystem_common.h
  libcxx/src/filesystem/operations.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91135.304085.patch
Type: text/x-patch
Size: 16410 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201110/e123596d/attachment-0001.bin>


More information about the libcxx-commits mailing list