[libcxx-commits] [PATCH] D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 10 01:24:24 PST 2020


mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

TODO: What would be the correct place to put this test? It essentially tests the path.member/path.construct, path.member/path.native.obs/named_overloads, path.member/path.append and path.member/path.concat, with respect to character set conversions.

I don't think the existing path tests really test actual conversion of chars that don't have the same value in all charsets, so this adds test coverage of the path class on posix systems as well.

This is as a separate patch for now, but could also be squashed into one of the later commits that implement the corresponding things for windows.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91133

Files:
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91133.304082.patch
Type: text/x-patch
Size: 12863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201110/8c453f8b/attachment.bin>


More information about the libcxx-commits mailing list