[libcxx-commits] [PATCH] D84045: [libcxx][lit] Add a new executor to collect test binaries

[Bryce Adelstein Lelbach via Phabricator via libcxx-commits]

wash added a comment.

Is the intention that this would be used with `PrefixExecutor`? I think it would be nice to have a named executor class specifically for this. In fact, instead of invoking a separate process, I'd prefer to have all of the logic in an executor class in our lit python code itself (e.g. in utils/libcxx/test/executor.py).



================
Comment at: libcxx/utils/copy_files.py:22
+    parser.add_argument('--output-dir', type=str, required=True)
+    parser.add_argument('--codesign_identity', type=str, required=False, default=None)
+    parser.add_argument('--env', type=str, nargs='*', required=False, default=dict())
----------------
Slight preference for this to be `--codesign-identity`, not `--codesign_identity`, to be consistent with the other ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84045/new/

https://reviews.llvm.org/D84045