[libcxx-commits] [PATCH] D56692: More calendar bits for <chrono>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 2 15:00:47 PST 2020


ldionne added a reviewer: libc++.
ldionne added a comment.

Marshall, are you ready to commit this? I haven't looked deeply, but it looks like you had addressed Eric's comments?



================
Comment at: libcxx/test/std/utilities/time/time.zone/time.zone.link/types.pass.cpp:35
+
+	ASSERT_NOEXCEPT(                            std::declval<const link&>().target());
+	ASSERT_SAME_TYPE(std::string_view, decltype(std::declval<const link&>().target()));
----------------
Weird indentation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56692/new/

https://reviews.llvm.org/D56692



More information about the libcxx-commits mailing list