[libcxx-commits] [PATCH] D80895: [libcxx] adds operator<=> for basic_string

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added inline comments.


================
Comment at: libcxx/include/string:362
-template<class charT, class traits, class Allocator>
-bool operator==(const charT* lhs, const basic_string<charT, traits, Allocator>& rhs) noexcept;
 
----------------
I think we should not delete them from the synopsis as they are used in pre C++20 mode. You could mark them with // until C++17 and then spaceship with // C++20


================
Comment at: libcxx/include/string:3909
 bool
 operator==(const basic_string<char, char_traits<char>, _Allocator>& __lhs,
            const basic_string<char, char_traits<char>, _Allocator>& __rhs) _NOEXCEPT
----------------
I think you are missing this specialization below. That said, I am unsure whether this is actually needed at all.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80895/new/

https://reviews.llvm.org/D80895