[libcxx-commits] [PATCH] D80452: [libc++] Complete overhaul of constexpr support in std::array

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

Thanks for fixing the nullptr thing, and thanks for all the work to improve tests here. Other than my one comment, this LGTM.



================
Comment at: libcxx/include/array:245
 
+#ifndef _LIBCPP_CXX03_LANG
+    union __wrapper {
----------------
This should be after C++11. In C++11 this won't be an aggregate (`__w` is a non-static member without initialization). 


================
Comment at: libcxx/include/array:269
+    const value_type* data() const _NOEXCEPT {return reinterpret_cast<const value_type*>(__elems_);}
+#endif
+
----------------
Nit: will you put a comment here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80452/new/

https://reviews.llvm.org/D80452