[libcxx-commits] [PATCH] D78763: Add optimization to basic_string::assign for compile-time known constant values.

Thu May 21 12:27:24 PDT 2020

ldionne added a comment.

In D78763#2049008 <https://reviews.llvm.org/D78763#2049008>, @mvels wrote:

> In D78763#2001599 <https://reviews.llvm.org/D78763#2001599>, @ldionne wrote:
>
> > Please make sure you update the ABI v2 abi list when you make these changes. It's currently broken (and this change will break it even more). You can run `make check-cxx-abilist` to see the failures.
> >
> > Or, I guess we can also have a discussion to disable the abi list tests for unstable ABIs, since it's not that useful I guess.
>
>
> Thanks Luis, I noticed the ABI list checks are remove from unstable, thanks!

They are removed from the unstable ABI, but not from the ABI v2. Those are different things (and I guess it doesn't really make sense for them to be different). But we should either decide that we don't test abi lists for ABI v2, or fix it. I suggest we fix it for now in order to make progress on this. You just need to update the ABI list for v2, it shouldn't be difficult.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78763/new/

https://reviews.llvm.org/D78763