[libcxx-commits] [PATCH] D80379: [libc++] Mark __u64toa and __u32toa as noexcept

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 21 09:09:12 PDT 2020


ldionne added a comment.

In D80379#2049116 <https://reviews.llvm.org/D80379#2049116>, @mclow.lists wrote:

> This is not sufficient; it just "moves the pain" from the callers code into the dylib.  All the functions in `charconv.cpp` need to be marked as `noexcept`.


Excellent point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80379/new/

https://reviews.llvm.org/D80379





More information about the libcxx-commits mailing list