[libcxx-commits] [libcxx] 93e8164 - [libc++] Remove workaround for DYLD_LIBRARY_PATH being passed to the compiler

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-05-15T13:53:45-04:00
New Revision: 93e8164546c384f91bfbfa27852e1f6d63a73809

URL: https://github.com/llvm/llvm-project/commit/93e8164546c384f91bfbfa27852e1f6d63a73809
DIFF: https://github.com/llvm/llvm-project/commit/93e8164546c384f91bfbfa27852e1f6d63a73809.diff

LOG: [libc++] Remove workaround for DYLD_LIBRARY_PATH being passed to the compiler

Since we're using the new testing format, DYLD_LIBRARY_PATH is not passed
to the compiler -- it's only passed to the programs we run as an argument
to the %{exec} substitution.

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/config.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/config.py b/libcxx/utils/libcxx/test/config.py
index 86e59eff73bb..6456620f9652 100644
--- a/libcxx/utils/libcxx/test/config.py
+++ b/libcxx/utils/libcxx/test/config.py
@@ -740,15 +740,9 @@ def configure_modules(self):
             self.cxx.useModules()
 
     def configure_substitutions(self):
-        tool_env = ''
-        if self.target_info.is_darwin():
-            # Do not pass DYLD_LIBRARY_PATH to the compiler, linker, etc. as
-            # these tools are not meant to exercise the just-built libraries.
-            tool_env += 'env DYLD_LIBRARY_PATH=""'
-
         sub = self.config.substitutions
         # Configure compiler substitutions
-        sub.append(('%{cxx}', '{} {}'.format(tool_env, pipes.quote(self.cxx.path))))
+        sub.append(('%{cxx}', pipes.quote(self.cxx.path)))
         sub.append(('%{libcxx_src_root}', self.libcxx_src_root))
         # Configure flags substitutions
         flags = self.cxx.flags + (self.cxx.modules_flags if self.cxx.use_modules else [])