[libcxx-commits] [PATCH] D62760: allocate_shared should call allocator_traits::construct

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared_construct.pass.cpp:130
+    FactoryAllocator<Private> factory_alloc;
+	return std::allocate_shared<Private>(factory_alloc, 42);
+}
----------------
Because of `construct` is currently implemented, this only works when passed exactly one argument. I'll fix that when I remove the rebind variadics. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62760/new/

https://reviews.llvm.org/D62760