[libcxx-commits] [PATCH] D74350: [libcxx][type_traits] Add C++20 changes to common_type

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Sorry, two more things as I look at the diff again locally.



================
Comment at: libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp:228
+//    -- Otherwise, if COND-RES(CREF(D1), CREF(D2)) denotes a type, let C
+//       denote the type decay_­t<COND-RES(CREF(D1), CREF(D2))>.
+void test_bullet_three_four() {
----------------
There's a weird non-printable character on this line (`<U+00AD>`). I noticed that by looking at the diff in `git`. Please watch out for those.


================
Comment at: libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp:231
+#if TEST_STD_VER >= 20
+  static_assert(std::is_same_v<std::common_type_t<int, bad_reference_wrapper<int>>, int>, "");
+  static_assert(std::is_same_v<std::common_type_t<bad_reference_wrapper<double>, double>, double>, "");
----------------
Don't we need to test with some cv qualified and ref types too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74350/new/

https://reviews.llvm.org/D74350