[libcxx-commits] [PATCH] D79888: libc++: include unistd.h if available to get some preprocessor macros

[Mara Sophie Grosch via Phabricator via libcxx-commits]

LittleFox94 added a comment.

In D79888#2034706 <https://reviews.llvm.org/D79888#2034706>, @ldionne wrote:

> I am slightly concerned that this also introduces a bunch of declarations in `__config`, which is the most included file of the library. That would also be the first time we include `unistd.h` in the libc++ headers (as opposed to the sources used to build the dylib). That might not be an issue, but it's something to keep in mind.


Another way would be to include `_newlib_version.h` if it exists, would that be better? Would then be a newlib specific patch.

> Is this necessary for libc++ to work with Newlib? I thought we already supported it as-is (we certainly have some code paths that are conditionals to it).

__config has a check for newlib which never works, due to the preprocessor macro not being set without an include (line 933 in the patched revision)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79888/new/

https://reviews.llvm.org/D79888