[libcxx-commits] [PATCH] D79888: libc++: include unistd.h if available to get some preprocessor macros

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I am slightly concerned that this also introduces a bunch of declarations in `__config`, which is the most included file of the library. That would also be the first time we include `unistd.h` in the libc++ headers (as opposed to the sources used to build the dylib). That might not be an issue, but it's something to keep in mind.

Is this necessary for libc++ to work with Newlib? I thought we already supported it as-is (we certainly have some code paths that are conditionals to it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79888/new/

https://reviews.llvm.org/D79888