[libcxx-commits] [PATCH] D70346: [libc++] [LWG3321] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D70346#2034133 <https://reviews.llvm.org/D70346#2034133>, @curdeius wrote:

> Do you know what was the purpose of redefining it?


To test internal aspects of the library. But I think @EricWF and I (at least) both agree that the debug mode of libc++ is not really working right now, and we were talking about rewriting it. This would get rid of most of the other ~130 redefines of `_LIBCPP_ASSERT`, I think.

To solve just this problem, would it make sense to `#define _NOEXCEPT` to nothing? I would argue it makes as much sense, since in theory this could have broken long ago on any other method that uses `_LIBCPP_ASSERT`. WDYT? Does that even work, or do we hit other issues when doing that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70346/new/

https://reviews.llvm.org/D70346