[libcxx-commits] [libcxxabi] 363393c - [libc++abi] Adjust XFAIL on macOS for bug that was fixed in recent OSes

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 12 14:00:15 PDT 2020


Author: Louis Dionne
Date: 2020-05-12T17:00:03-04:00
New Revision: 363393c4b35997c67e6b282bd2be9022a7bfed25

URL: https://github.com/llvm/llvm-project/commit/363393c4b35997c67e6b282bd2be9022a7bfed25
DIFF: https://github.com/llvm/llvm-project/commit/363393c4b35997c67e6b282bd2be9022a7bfed25.diff

LOG: [libc++abi] Adjust XFAIL on macOS for bug that was fixed in recent OSes

Added: 
    

Modified: 
    libcxxabi/test/thread_local_destruction_order.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxxabi/test/thread_local_destruction_order.pass.cpp b/libcxxabi/test/thread_local_destruction_order.pass.cpp
index 388cdc439fb0..e9ffd2237e4f 100644
--- a/libcxxabi/test/thread_local_destruction_order.pass.cpp
+++ b/libcxxabi/test/thread_local_destruction_order.pass.cpp
@@ -6,10 +6,19 @@
 //
 //===----------------------------------------------------------------------===//
 
-// Darwin TLV finalization routines fail when creating a thread-local variable
-// in the destructor for another thread-local variable:
-// http://lists.llvm.org/pipermail/cfe-dev/2016-November/051376.html
-// XFAIL: darwin
+// Darwin TLV finalization routines used to fail when creating a thread-local
+// variable in the destructor for another thread-local variable:
+//  - http://lists.llvm.org/pipermail/cfe-dev/2016-November/051376.html
+//  - rdar://29523281
+// This was fixed in dyld in macos 10.15.
+//
+// XFAIL: macosx10.14
+// XFAIL: macosx10.13
+// XFAIL: macosx10.12
+// XFAIL: macosx10.11
+// XFAIL: macosx10.10
+// XFAIL: macosx10.9
+
 // UNSUPPORTED: c++98, c++03
 // UNSUPPORTED: libcxxabi-no-threads
 


        


More information about the libcxx-commits mailing list