[libcxx-commits] [PATCH] D70343: Add a `_LIBCPP_HARDEN` define

[Chris Palmer via Phabricator via libcxx-commits]

palmer added a comment.

Thanks!

Yes, I am still testing the binary size question. I hope to get back to you on that this week, and in any case won't land this until I have got some answer.

There's also the question of the meaning of "harden" vs. "debug", and "debug = 0". I believe that "harden" has a more clear meaning than "debug = 0", which looks like it means "don't debug; optimize for production". or, at most, "do debug, but minimally". If I were a random build engineer setting up the build for some product, I would never guess that "debug = 0" means to turn on hardening checks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70343/new/

https://reviews.llvm.org/D70343