[libcxx-commits] [PATCH] D60422: Remove default parameters (P0935R0)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

It's been a while, but I'll review this if you update it with my comments.



================
Comment at: test/std/containers/container.adaptors/queue/queue.defn/default_constructor.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
zoecarver wrote:
> Before I spend a lot of time writing tests for this, I want to check that I am writing the correct tests. I am going to use this test as a "template" for other tests. @EricWF how does this look? 
IIUC, you're just trying to test that the type is implicitly default constructible. You could add a support header that contains generic tests for that, like `test_implicitly_default_constructible<T>()`, and then you'd simply use `test_implicitly_default_constructible<std::queue<T>>()`, etc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60422/new/

https://reviews.llvm.org/D60422