[libcxx-commits] [PATCH] D65721: Make rotate a constexpr

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 12 08:34:54 PDT 2020


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: broadwaylamb.


================
Comment at: libcxx/include/algorithm:1862
 {
+#ifdef is_constant_evaluated
+    if (is_constant_evaluated())
----------------
This doesn't work because `is_constant_evaluated` is not a macro. We have the macro `_LIBCPP_HAS_NO_BUILTIN_IS_CONSTANT_EVALUATED` that tells you whether `std::is_constant_evaluated` is supported.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65721/new/

https://reviews.llvm.org/D65721





More information about the libcxx-commits mailing list