[libcxx-commits] [PATCH] D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584)

[David Zarzycki via Phabricator via libcxx-commits]

davezarzycki added a comment.

In D66610#2028442 <https://reviews.llvm.org/D66610#2028442>, @zoecarver wrote:

> > I don't know of such a flag. My two stage setup actually installs the first stage and then uses the first stage to compile/test the second stage.
>
> Fair enough. I'll try to set up a VM for testing (which I honestly should have done long ago) and install/test this weekend.


I can see the advantage of a VM, but personally, I don't go that far. Non-standard install prefixes are handy sometimes. For example, have the first phase build and install with `-DCMAKE_INSTALL_PREFIX=/some/other/path` and then `export PATH=/some/other/path/bin:$PATH` before running the second phase. When you're done, `rm -rf /some/other/path`. This assumes, of course, that one is already using `-DCMAKE_C_COMPILER=clang` and `-DCMAKE_CXX_COMPILER=clang++`

Here are all the flags I use in case it matter. And yes, the various install prefixes are overridden during my phased tests.

cmake -G Ninja \

  -DCMAKE_INSTALL_PREFIX=/my/production/compiler/path \
  -DLIBCXX_INSTALL_PREFIX=/my/production/compiler/path \
  -DLIBCXX_INSTALL_HEADER_PREFIX=/my/production/compiler/path \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++ \
  -DCMAKE_C_FLAGS="$CFLAGS" \
  -DCMAKE_CXX_FLAGS="$CXXFLAGS" \
  -DCMAKE_LINKER=ld.lld \
  -DLLVM_TARGETS_TO_BUILD="X86;AArch64;PowerPC;RISCV" \
  -DLLVM_INCLUDE_GO_TESTS=FALSE \
  -DLLVM_TOOL_LTO_BUILD=FALSE \
  -DLLVM_ENABLE_PROJECTS="clang;lld;libcxxabi;libcxx;libc" \
  -DLLVM_INCLUDE_GO_TESTS=FALSE \
  -DLLVM_LIBDIR_SUFFIX=64 \
  -DLLVM_USE_LINKER=lld \
  -DLLVM_ENABLE_LIBCXX=TRUE \
  -DCLANG_DEFAULT_LINKER=lld \
  -DCLANG_DEFAULT_CXX_STDLIB="libc++" \
  -DLIBCXX_ENABLE_SHARED=FALSE \
  -DLIBCXXABI_ENABLE_SHARED=FALSE \
  -DLIBUNWIND_ENABLE_SHARED=FALSE \
  -DLLVM_LIBC_ENABLE_LINTING=FALSE


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66610/new/

https://reviews.llvm.org/D66610