[libcxx-commits] [PATCH] D69603: [libcxx] Add deduction guides for shared_ptr and weak_ptr

[Logan Smith via Phabricator via libcxx-commits]

logan-5 marked an inline comment as done.
logan-5 added a comment.

Ack. It fails because there's a leak because a dummy deleter I used (`D` in deduction.pass.cpp) is a no-op. I suppose it should `delete` its argument as expected.

Should I submit another patch? Or does someone have the power to just commit the fix directly?



================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/deduction.pass.cpp:26
+struct D {
+  void operator()(void*) const {}
+};
----------------
Here's the offending line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69603/new/

https://reviews.llvm.org/D69603