[libcxx-commits] [PATCH] D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584)

[David Zarzycki via Phabricator via libcxx-commits]

davezarzycki added a comment.

Hello, git bisect of a private stage two builder identified this commit as breaking lld's test suite. Can we either revert this or commit a quick fix to the regular expressions in lld's test suite?

  FAIL: lld :: ELF/vs-diagnostics-duplicate-split.s (63239 of 63760)
  ******************** TEST 'lld :: ELF/vs-diagnostics-duplicate-split.s' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /tmp/_update_lc/t/bin/llvm-mc -filetype=obj -triple=x86_64 /home/dave/s/lp/lld/test/ELF/vs-diagnostics-duplicate-split.s -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate-split.s.tmp.o
  : 'RUN: at line 3';   not /tmp/_update_lc/t/bin/ld.lld --vs-diagnostics --shared /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate-split.s.tmp.o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate-split.s.tmp.o -o /dev/null 2>&1 | /tmp/_update_lc/t/bin/FileCheck /home/dave/s/lp/lld/test/ELF/vs-diagnostics-duplicate-split.s
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/s/lp/lld/test/ELF/vs-diagnostics-duplicate-split.s:5:11: error: CHECK: expected string not found in input
  // CHECK: /tmp{{/|\\}}duplicate.s(15): error: duplicate symbol: foo
            ^
  <stdin>:1:1: note: scanning from here
  s(15): error: duplicate symbol: foo
  ^
  
  --
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  FAIL: lld :: ELF/vs-diagnostics-undefined-symbol-3.s (63255 of 63760)
  ******************** TEST 'lld :: ELF/vs-diagnostics-undefined-symbol-3.s' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /tmp/_update_lc/t/bin/llvm-mc -filetype=obj -triple=x86_64-pc-linux /home/dave/s/lp/lld/test/ELF/vs-diagnostics-undefined-symbol-3.s -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-undefined-symbol-3.s.tmp1.o
  : 'RUN: at line 3';   not /tmp/_update_lc/t/bin/ld.lld --vs-diagnostics /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-undefined-symbol-3.s.tmp1.o -o /dev/null 2>&1    | /tmp/_update_lc/t/bin/FileCheck -check-prefix=ERR -check-prefix=CHECK /home/dave/s/lp/lld/test/ELF/vs-diagnostics-undefined-symbol-3.s
  : 'RUN: at line 5';   /tmp/_update_lc/t/bin/ld.lld --vs-diagnostics --warn-unresolved-symbols /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-undefined-symbol-3.s.tmp1.o -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-undefined-symbol-3.s.tmpout 2>&1    | /tmp/_update_lc/t/bin/FileCheck -check-prefix=WARN -check-prefix=CHECK /home/dave/s/lp/lld/test/ELF/vs-diagnostics-undefined-symbol-3.s
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/s/lp/lld/test/ELF/vs-diagnostics-undefined-symbol-3.s:8:9: error: ERR: expected string not found in input
  // ERR: undef3.s(15): error: undefined symbol: foo
          ^
  <stdin>:1:1: note: scanning from here
  s(15): error: undefined symbol: foo
  ^
  
  --
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  FAIL: lld :: ELF/vs-diagnostics-undefined-hidden.s (63265 of 63760)
  ******************** TEST 'lld :: ELF/vs-diagnostics-undefined-hidden.s' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /tmp/_update_lc/t/bin/llvm-mc -filetype=obj -triple=x86_64 /home/dave/s/lp/lld/test/ELF/vs-diagnostics-undefined-hidden.s -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-undefined-hidden.s.tmp.o
  : 'RUN: at line 3';   not /tmp/_update_lc/t/bin/ld.lld --vs-diagnostics -shared /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-undefined-hidden.s.tmp.o -o /dev/null 2>&1    | /tmp/_update_lc/t/bin/FileCheck /home/dave/s/lp/lld/test/ELF/vs-diagnostics-undefined-hidden.s
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/s/lp/lld/test/ELF/vs-diagnostics-undefined-hidden.s:6:11: error: CHECK: expected string not found in input
  // CHECK: undef.s(15): error: undefined hidden symbol: foo
            ^
  <stdin>:1:1: note: scanning from here
  s(15): error: undefined hidden symbol: foo
  ^
  
  --
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  FAIL: lld :: ELF/vs-diagnostics-duplicate.s (63267 of 63760)
  ******************** TEST 'lld :: ELF/vs-diagnostics-duplicate.s' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /tmp/_update_lc/t/bin/llvm-mc -filetype=obj -triple=x86_64-unknown-linux /home/dave/s/lp/lld/test/ELF/vs-diagnostics-duplicate.s -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate.s.tmp1.o
  : 'RUN: at line 3';   /tmp/_update_lc/t/bin/llvm-mc -filetype=obj -triple=x86_64-unknown-linux /home/dave/s/lp/lld/test/ELF/Inputs/vs-diagnostics-duplicate2.s -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate.s.tmp2.o
  : 'RUN: at line 4';   /tmp/_update_lc/t/bin/llvm-mc -filetype=obj -triple=x86_64-unknown-linux /home/dave/s/lp/lld/test/ELF/Inputs/vs-diagnostics-duplicate3.s -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate.s.tmp3.o
  : 'RUN: at line 5';   not /tmp/_update_lc/t/bin/ld.lld --vs-diagnostics /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate.s.tmp1.o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate.s.tmp2.o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate.s.tmp3.o -o /dev/null 2>&1 | /tmp/_update_lc/t/bin/FileCheck /home/dave/s/lp/lld/test/ELF/vs-diagnostics-duplicate.s
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/s/lp/lld/test/ELF/vs-diagnostics-duplicate.s:8:11: error: CHECK: expected string not found in input
  // CHECK: duplicate.s(15): error: duplicate symbol: bar
            ^
  <stdin>:1:1: note: scanning from here
  s(15): error: duplicate symbol: bar
  ^
  
  --
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  FAIL: lld :: ELF/vs-diagnostics-dynamic-relocation.s (63280 of 63760)
  ******************** TEST 'lld :: ELF/vs-diagnostics-dynamic-relocation.s' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /tmp/_update_lc/t/bin/llvm-mc -filetype=obj -triple=x86_64-pc-linux /home/dave/s/lp/lld/test/ELF/vs-diagnostics-dynamic-relocation.s -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-dynamic-relocation.s.tmp.o
  : 'RUN: at line 3';   not /tmp/_update_lc/t/bin/ld.lld -shared --vs-diagnostics /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-dynamic-relocation.s.tmp.o -o /dev/null 2>&1 | /tmp/_update_lc/t/bin/FileCheck /home/dave/s/lp/lld/test/ELF/vs-diagnostics-dynamic-relocation.s
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/s/lp/lld/test/ELF/vs-diagnostics-dynamic-relocation.s:5:11: error: CHECK: expected string not found in input
  // CHECK: dyn.s(15): error: can't create dynamic relocation R_X86_64_64 against local symbol in readonly segment; recompile object files with -fPIC or pass '-Wl,-z,notext' to allow text relocations in the output
            ^
  <stdin>:1:1: note: scanning from here
  s(15): error: can't create dynamic relocation R_X86_64_64 against local symbol in readonly segment; recompile object files with -fPIC or pass '-Wl,-z,notext' to allow text relocations in the output
  ^
  
  --
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  
  10 warning(s) in tests
  ********************
  Failing Tests (5):
    lld :: ELF/vs-diagnostics-duplicate-split.s
    lld :: ELF/vs-diagnostics-duplicate.s
    lld :: ELF/vs-diagnostics-dynamic-relocation.s
    lld :: ELF/vs-diagnostics-undefined-hidden.s
    lld :: ELF/vs-diagnostics-undefined-symbol-3.s
  
  
  Testing Time: 144.74s
    Unsupported Tests  : 11836
    Expected Passes    : 51763
    Expected Failures  :   156
    Unexpected Failures:     5
  FAILED: CMakeFiles/check-all


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66610/new/

https://reviews.llvm.org/D66610