[libcxx-commits] [PATCH] D78200: [libc++] [test] Generate static_test_env on the fly

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb added a subscriber: danalbert.
broadwaylamb added a comment.

In D78200#2025807 <https://reviews.llvm.org/D78200#2025807>, @EricWF wrote:

> Buildbot's `Git` module allows you to pass in a `config` object,  so I don't understand the problem.
>  http://docs.buildbot.net/0.8.9/manual/cfg-buildsteps.html#git
>
> Are you using an even older version of Buildbot?
>  If so you can always insert the symlink config option by putting it in a .gitconfig file.


I didn't know about this, thanks.

However, the question is whether we want to depend on the presence of this filesystem feature on the host machine. I personally was surprised to see test failures caused by this, when everything else was in place. We could document that whoever wants to run libc++ tests in this setup will need to do some extra work setting up their environment and even re-cloning the whole monorepo (which takes some time). But I think it is too much to ask the user to do.

Besides, @danalbert has mentioned that Android would also benefit from this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78200/new/

https://reviews.llvm.org/D78200