[libcxx-commits] [PATCH] D72640: [libcxx] Qualify make_pair in searcher implementations to prevent ADL

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 7 09:05:24 PDT 2020


ldionne added a comment.

Thanks for the patch! Committed as

  commit 5b4a98eb58aa7672bbdc5e31e573f8f1220fc9c7
  Author: Logan Smith <logan.r.smith0 at gmail.com>
  Date:   Thu May 7 11:54:25 2020 -0400
  
      [libcxx] Qualify make_pair in searcher implementations to prevent ADL
  
      This patch adds `_VSTD::` to some calls to `make_pair` inside the
      implementations of searchers, to prevent things exploding if there is
      a make_pair in an associated namespace of a user-defined type.
      https://godbolt.org/z/xAFG98
  
      Differential Revision: https://reviews.llvm.org/D72640


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72640/new/

https://reviews.llvm.org/D72640





More information about the libcxx-commits mailing list