[libcxx-commits] [PATCH] D72640: [libcxx] Qualify make_pair in searcher implementations to prevent ADL

Logan Smith via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 6 10:46:45 PDT 2020


logan-5 marked an inline comment as done.
logan-5 added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/alg.search/search.pass.cpp:113
+void 
+adl_test() 
+{
----------------
I used this formatting (and the rest of the formatting in this diff) to be consistent with the pre-existing surrounding code in this file. The clang-tidy lint check is complaining here though. Is it more important to make those checks pass, or be consistent with the surrounding file? Genuine question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72640/new/

https://reviews.llvm.org/D72640





More information about the libcxx-commits mailing list