[libcxx-commits] [PATCH] D78427: [libcxx] Add c++20 <numbers>

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

Thanks for the fast update!



================
Comment at: libcxx/include/numbers:193
+inline constexpr
+T phi_v<T> = T(1.618033988749894848204586834365638117L);
+
----------------
Where did you take all the values? Do you have a link to e.g. a math notebook online where you computed all those?


================
Comment at: libcxx/test/std/numerics/numbers/numbers.pass.cpp:76
+  return 0;
+
+}
----------------
Have you clang-formatted your patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78427/new/

https://reviews.llvm.org/D78427