[libcxx-commits] [PATCH] D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584)

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 20 14:40:10 PDT 2020


zoecarver updated this revision to Diff 251761.
zoecarver added a comment.

- Remove now valid bad escape tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66610/new/

https://reviews.llvm.org/D66610

Files:
  libcxx/test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp


Index: libcxx/test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp
===================================================================
--- libcxx/test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp
+++ libcxx/test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp
@@ -32,15 +32,11 @@
 int main(int, char**)
 {
     assert(error_escape_thrown("[\\a]"));
-    assert(error_escape_thrown("\\a"));
     assert(error_escape_thrown("\\"));
 
     assert(error_escape_thrown("[\\e]"));
-    assert(error_escape_thrown("\\e"));
 
     assert(error_escape_thrown("[\\c:]"));
-    assert(error_escape_thrown("\\c:"));
-    assert(error_escape_thrown("\\c"));
     assert(!error_escape_thrown("[\\cA]"));
     assert(!error_escape_thrown("\\cA"));
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66610.251761.patch
Type: text/x-patch
Size: 759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200320/1fe94615/attachment.bin>


More information about the libcxx-commits mailing list