[libcxx-commits] [PATCH] D76431: Introduce LIBUNWIND_LIT_ARGS, LIBCXXABI_LIT_ARGS and LIBCXX_LIT_AGRS

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I personally think we should move away from tying CMake and lit together by funneling lit arguments through it. Instead, it would be better to store special `lit.cfg` files in `libcxx/` for use by bots. But we're not quite there yet, and this patch has the effect of decoupling libcxx/libcxxabi/libunwind from LLVM global variables, so I'm sort-of OK with it. I'd like to move towards a future where we don't need to process the CMake files in `llvm/*` to build the runtimes.



================
Comment at: libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake:127
     endif()
-    set(LLVM_LIT_ARGS "${LIT_ARGS_DEFAULT}" CACHE STRING "Default options for lit")
+    if (DEFINED LIBCXX_LIT_ARGS)
+      # libc++-specific LIT args always win over generic LIT args
----------------
Why isn't that in `libcxx/CMakeLists.txt`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76431/new/

https://reviews.llvm.org/D76431