[libcxx-commits] [PATCH] D76256: [libc++] Require the use of clang-verify in .fail.cpp tests that don't fail without it

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Some tests do not fail at all when -verify is not supported, unless some
arbitrary warning flag is added to make them fail. We currently used
-Werror=unused-result to make them fail, but doing so makes the test
suite a lot more inscrutable. It seems better to just disable those
tests when -verify is not supported.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76256

Files:
  libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.cxx2a.fail.cpp
  libcxx/test/libcxx/diagnostics/enable_nodiscard.fail.cpp
  libcxx/test/libcxx/diagnostics/enable_nodiscard_disable_after_cxx17.fail.cpp
  libcxx/test/libcxx/diagnostics/enable_nodiscard_disable_nodiscard_ext.fail.cpp
  libcxx/test/libcxx/diagnostics/nodiscard_aftercxx17.fail.cpp
  libcxx/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp
  libcxx/test/libcxx/thread/thread.lock/thread.lock.guard/nodiscard.fail.cpp
  libcxx/test/std/containers/associative/map/map.access/empty.fail.cpp
  libcxx/test/std/containers/associative/multimap/empty.fail.cpp
  libcxx/test/std/containers/associative/multiset/empty.fail.cpp
  libcxx/test/std/containers/associative/set/empty.fail.cpp
  libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.members/empty.fail.cpp
  libcxx/test/std/containers/container.adaptors/queue/queue.defn/empty.fail.cpp
  libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.fail.cpp
  libcxx/test/std/containers/sequences/array/empty.fail.cpp
  libcxx/test/std/containers/sequences/deque/deque.capacity/empty.fail.cpp
  libcxx/test/std/containers/sequences/forwardlist/empty.fail.cpp
  libcxx/test/std/containers/sequences/list/list.capacity/empty.fail.cpp
  libcxx/test/std/containers/sequences/vector.bool/empty.fail.cpp
  libcxx/test/std/containers/sequences/vector/vector.capacity/empty.fail.cpp
  libcxx/test/std/containers/unord/unord.map/empty.fail.cpp
  libcxx/test/std/containers/unord/unord.multimap/empty.fail.cpp
  libcxx/test/std/containers/unord/unord.multiset/empty.fail.cpp
  libcxx/test/std/containers/unord/unord.set/empty.fail.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.decompose/empty.fail.cpp
  libcxx/test/std/iterators/iterator.container/empty.array.fail.cpp
  libcxx/test/std/iterators/iterator.container/empty.container.fail.cpp
  libcxx/test/std/iterators/iterator.container/empty.initializer_list.fail.cpp
  libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_array_ptr.fail.cpp
  libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_ptr.fail.cpp
  libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size.fail.cpp
  libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_nothrow.fail.cpp
  libcxx/test/std/language.support/support.dynamic/ptr.launder/launder.nodiscard.fail.cpp
  libcxx/test/std/re/re.results/re.results.size/empty.fail.cpp
  libcxx/test/std/strings/basic.string/string.capacity/empty.fail.cpp
  libcxx/test/std/strings/string.view/string.view.capacity/empty.fail.cpp
  libcxx/test/std/thread/futures/futures.async/async.fail.cpp
  libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.members/allocate_size.fail.cpp
  libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.members/allocate_size_hint.fail.cpp
  libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/allocate.fail.cpp
  libcxx/test/std/utilities/memory/default.allocator/allocator.members/allocate.fail.cpp
  libcxx/utils/libcxx/test/format.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76256.250637.patch
Type: text/x-patch
Size: 29980 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200316/04e75d0d/attachment-0001.bin>