[libcxx-commits] [PATCH] D74577: [libcxx][span] Implement P1976R2

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I think you're missing the update of the feature-test macro? eel.is/c++draft says: `#define __cpp_lib_span                              202002L`



================
Comment at: libcxx/include/span:67
     template <class Container>
         constexpr span(const Container& cont);
     constexpr span(const span& other) noexcept = default;
----------------
Could you please adjust the synopsis too?


================
Comment at: libcxx/include/span:228
+    _LIBCPP_INLINE_VISIBILITY
+        constexpr explicit span(      _Container& __c,
+            enable_if_t<__is_span_compatible_container<_Container, _Tp>::value, nullptr_t> = nullptr)
----------------
Can you walk me through why we don't have a single `_Container&&` like in the spec of P1976R2?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74577/new/

https://reviews.llvm.org/D74577