[libcxx-commits] [PATCH] D76183: [libcxx] fix CMake install target for libc++experimental

Fabio Fracassi via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 14 12:20:09 PDT 2020


Fabio created this revision.
Fabio added reviewers: mclow.lists, EricWF, abdulras.
Herald added subscribers: libcxx-commits, mgorny.

The `install` command for lib cxx was not getting the right target since it used two unused variables as input instead of the correct target.
This fixes installation for libc++experimental


Repository:
  rCXX libc++

https://reviews.llvm.org/D76183

Files:
  libcxx/src/CMakeLists.txt


Index: libcxx/src/CMakeLists.txt
===================================================================
--- libcxx/src/CMakeLists.txt
+++ libcxx/src/CMakeLists.txt
@@ -349,7 +349,7 @@
   endif()
 
   if(LIBCXX_INSTALL_EXPERIMENTAL_LIBRARY)
-    install(TARGETS ${LIBCXX_INSTALL_TARGETS} ${experimental_lib}
+    install(TARGETS cxx_experimental
       LIBRARY DESTINATION ${LIBCXX_INSTALL_PREFIX}${LIBCXX_INSTALL_LIBRARY_DIR} COMPONENT cxx
       ARCHIVE DESTINATION ${LIBCXX_INSTALL_PREFIX}${LIBCXX_INSTALL_LIBRARY_DIR} COMPONENT cxx
       RUNTIME DESTINATION ${LIBCXX_INSTALL_PREFIX}bin COMPONENT cxx)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76183.250372.patch
Type: text/x-patch
Size: 602 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200314/912928b4/attachment.bin>


More information about the libcxx-commits mailing list