[libcxx-commits] [PATCH] D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 11 12:29:43 PDT 2020


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM as a band-aid, however I believe we need to dissociate the core logic of building libc++ and libc++abi from how we test it. That's because there's way too many ways to test libc++/libc++abi, and having all of it in the CMake files creates a lot of complexity.

But this is just hand-waving at this point, so let's move forward with this until we are closer to addressing the real problem I'm thinking about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71894/new/

https://reviews.llvm.org/D71894





More information about the libcxx-commits mailing list