[libcxx-commits] [PATCH] D75991: [libc++] [cmake] Better diagnostics for missing abi library headers

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but in the future I think it would be reasonable to just require libc++ and libc++abi sources when building either one of them. That would simplify a lot of searching logic and we could start sharing stuff between the two. And concretely, I think it wouldn't change much since we're in the monorepo anyway.

@broadwaylamb I think you might have some funky requirements around that -- would it be problematic for you if we required a monorepo checkout when building libc++ or libc++abi?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75991/new/

https://reviews.llvm.org/D75991