[libcxx-commits] [PATCH] D70815: Enable `-funwind-tables` flag when building libunwind
Rasmus Ahlberg via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jun 23 01:01:03 PDT 2020
raahlb added a comment.
Herald added projects: LLVM, libunwind.
Herald added a subscriber: llvm-commits.
Herald added a reviewer: libunwind.
In D70815#1768359 <https://reviews.llvm.org/D70815#1768359>, @mstorsjo wrote:
> I went ahead and reverted this, as it broke how some cmake tests within libunwind work.
> As this disables linking, it falsely makes any test succeed that depends on linking, and there's a few such tests in cmake/config-ix.cmake (`check_library_exists(c fopen "" LIBUNWIND_HAS_C_LIB)`, `check_library_exists(dl dladdr "" LIBUNWIND_HAS_DL_LIB)`, etc).
> Therefore, `set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)` has to be carefully placed at a spot where all such tests that does require linking already has been completed.
This was fixed in a later commit, correct?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits