[libcxx-commits] [PATCH] D78763: Add optimization to basic_string::assign for compile-time known constant values.

[Martijn Vels via Phabricator via libcxx-commits]

mvels added a comment.

I'm mystified why the build fails, it fails on applying the patch:

  $ ./scripts/buildkite/apply_patch.sh
  repository exist, will reuse
  working dir /mnt/disks/ssd0/agent/llvm-project-fork
  Syncing local, origin and upstream...
  refresh of master branch completed
  Getting dependencies of 271828
  Base revision is cd2553de77f2c3206deaa261a15cc7520ff2ff56
  git reset, git cleanup...
  Analyzing D78763
  Applying diff 271828 for revision D78763...
  Traceback (most recent call last):
    File "scripts/phabtalk/apply_patch2.py", line 331, in <module>
      patcher.run()
    File "scripts/phabtalk/apply_patch2.py", line 124, in run
      self._apply_diff(self.diff_id, revision_id)
    File "scripts/phabtalk/apply_patch2.py", line 240, in _apply_diff
      raise Exception('Applying patch failed:\n{}'.format(proc.stdout + proc.stderr))
  Exception: Applying patch failed:
  error: patch failed: libcxx/include/string:1528
  error: libcxx/include/string: patch does not apply
  error: patch failed: libcxx/include/__string:184
  error: libcxx/include/__string: patch does not apply

Which I have no clue .... why?   I locally pulled, confirmed (and uploaded) the diff from "git diff origin", yet it fails... Not sure if I should dig into rev cd2553de77f2c3206deaa261a15cc7520ff2ff56 <https://reviews.llvm.org/rGcd2553de77f2c3206deaa261a15cc7520ff2ff56> or the whys here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78763/new/

https://reviews.llvm.org/D78763