[libcxx-commits] [PATCH] D80891: [libcxx] adds operator<=> for basic_string_view
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jun 18 09:13:29 PDT 2020
cjdb marked 2 inline comments as done.
cjdb added a comment.
I think all the comments requesting changes have been addressed now. @miscco @ericwf could you please confirm?
Comment at: libcxx/include/__string:469
typedef mbstate_t state_type;
+ #if !defined(_LIBCPP_HAS_NO_SPACESHIP_OPERATOR)
+ using comparison_category = strong_ordering;
> `#if` blocks should be left justified.
Whoops, I misunderstood this to mean "please justify why you're using an `#if` block" and not "please remove the spaces before `#if`". Fixed up now.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits