[libcxx-commits] [PATCH] D81414: [libcxx] Fix LWG 2875: shared_ptr::shared_ptr(Y*, D, […]) constructors should be constrained.

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 9 22:01:45 PDT 2020


zoecarver added a comment.

> Do we have tests that shared_ptr isn't constructible from incompatible array types? If not, could we add some?

The `__compatible_with` trait removes the array extent. And (AFAIK) there are no array types that are convertible where their elements aren't. I'll make another patch to add tests that ensure we *can* construct a `shared_ptr` with array types that aren't convertible but where their elements are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81414/new/

https://reviews.llvm.org/D81414





More information about the libcxx-commits mailing list