[libcxx-commits] [PATCH] D81417: [libcxx] Fix LWG 2874: Constructor shared_ptr::shared_ptr(Y*) should be constrained.
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jun 9 21:29:45 PDT 2020
zoecarver marked an inline comment as done.
zoecarver added inline comments.
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/shared_ptr_Y.pass.cpp:122
+// This should work in C++03 but we get errors when trying to do SFINAE with the delete operator.
+#if STD_TEST_VERSION >= 11
> `STD_TEST_VERSION` doesn't exist, it's `TEST_STD_VER`.
> To catch these sorts of errors, it can be good to add tests and witness their failure before actually fixing them.
Oops, you're right. Somehow that got suck in my clipboard history.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits