[libcxx-commits] [PATCH] D81438: [libc++] Work around gcc/Power9 bug in `include/thread`

Tue Jun 9 08:46:06 PDT 2020

jdenny added a comment.

In D81438#2082403 <https://reviews.llvm.org/D81438#2082403>, @ldionne wrote:

> Can you confirm that basically 0583d9ea8d5edc60d84971ced29db042b59302ba should not have been committed, since the original fix 3bf63cf3b366d3a57cf5cbad4112a6abf6c0c3b1 was correct in the first place. And all this does is revert 0583d9ea8d5edc60d84971ced29db042b59302ba.

Yes, that's my understanding (and I just checked that git revert produces the same result). I've updated the summary to clarify this.

> I did read the bug report discussion and that is my understanding, I just want to double check because the bug report discussion is tortuous. If I got that right, LGTM.

Thanks for the quick review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81438/new/

https://reviews.llvm.org/D81438